From 50670946f04257cc2110facbc61884e2cf0d8327 Mon Sep 17 00:00:00 2001 From: Kenton Groombridge Date: Fri, 6 May 2022 21:16:29 -0400 Subject: [PATCH] term, init: allow systemd to watch and watch reads on unallocated ttys As of systemd 250, systemd needs to be able to add a watch on and watch reads on unallocated ttys in order to start getty. systemd[55548]: getty@tty1.service: Failed to set up standard input: Permission denied systemd[55548]: getty@tty1.service: Failed at step STDIN spawning /sbin/agetty: Permission denied time->Fri May 6 21:17:58 2022 type=PROCTITLE msg=audit(1651886278.452:1770): proctitle="(agetty)" type=PATH msg=audit(1651886278.452:1770): item=0 name="/dev/tty1" inode=18 dev=00:05 mode=020620 ouid=0 ogid=5 rdev=04:01 obj=system_u:object_r:tty_device_t:s0 nametype=NORMAL cap_fp=0 cap_fi=0 cap_fe=0 cap_fver=0 cap_frootid=0 type=CWD msg=audit(1651886278.452:1770): cwd="/" type=SYSCALL msg=audit(1651886278.452:1770): arch=c000003e syscall=254 success=no exit=-13 a0=3 a1=60ba5c21e020 a2=18 a3=23 items=1 ppid=1 pid=55551 auid=4294967295 uid=0 gid=0 euid=0 suid=0 fsuid=0 egid=0 sgid=0 fsgid=0 tty=(none) ses=4294967295 comm="(agetty)" exe="/lib/systemd/systemd" subj=system_u:system_r:init_t:s0 key=(null) type=AVC msg=audit(1651886278.452:1770): avc: denied { watch watch_reads } for pid=55551 comm="(agetty)" path="/dev/tty1" dev="devtmpfs" ino=18 scontext=system_u:system_r:init_t:s0 tcontext=system_u:object_r:tty_device_t:s0 tclass=chr_file permissive=0 Upstream-Status: Backport [https://github.com/SELinuxProject/refpolicy/commit/308ab9f69a4623f5dace8da151e70c6316f055a8] Signed-off-by: Kenton Groombridge Signed-off-by: Yi Zhao --- policy/modules/kernel/terminal.if | 38 +++++++++++++++++++++++++++++++ policy/modules/system/init.te | 2 ++ 2 files changed, 40 insertions(+) diff --git a/policy/modules/kernel/terminal.if b/policy/modules/kernel/terminal.if index e8c0735eb..6e9f654ac 100644 --- a/policy/modules/kernel/terminal.if +++ b/policy/modules/kernel/terminal.if @@ -1287,6 +1287,44 @@ interface(`term_dontaudit_use_unallocated_ttys',` dontaudit $1 tty_device_t:chr_file rw_chr_file_perms; ') +######################################## +## +## Watch unallocated ttys. +## +## +## +## Domain allowed access. +## +## +# +interface(`term_watch_unallocated_ttys',` + gen_require(` + type tty_device_t; + ') + + dev_list_all_dev_nodes($1) + allow $1 tty_device_t:chr_file watch; +') + +######################################## +## +## Watch reads on unallocated ttys. +## +## +## +## Domain allowed access. +## +## +# +interface(`term_watch_reads_unallocated_ttys',` + gen_require(` + type tty_device_t; + ') + + dev_list_all_dev_nodes($1) + allow $1 tty_device_t:chr_file watch_reads; +') + ######################################## ## ## Get the attributes of all tty device nodes. diff --git a/policy/modules/system/init.te b/policy/modules/system/init.te index 5a19f0e43..24cef0924 100644 --- a/policy/modules/system/init.te +++ b/policy/modules/system/init.te @@ -518,6 +518,8 @@ ifdef(`init_systemd',` term_create_devpts_dirs(init_t) term_create_ptmx(init_t) term_create_controlling_term(init_t) + term_watch_unallocated_ttys(init_t) + term_watch_reads_unallocated_ttys(init_t) # udevd is a "systemd kobject uevent socket activated daemon" udev_create_kobject_uevent_sockets(init_t) -- 2.25.1