From af4b8cb780587aa736692a3baa76b60474f19c5d Mon Sep 17 00:00:00 2001 From: Enrico Scholz Date: Mon, 18 Mar 2024 12:14:21 +0100 Subject: [PATCH] lib/copydir:copy_entry(): use temporary stat buffer There are no guarantees that fstatat() does not clobber the stat buffer on errors. Use a temporary buffer so that the following code sees correct attributes of the source entry. Upstream-Status: Submitted [https://github.com/shadow-maint/shadow/pull/974] Signed-off-by: Enrico Scholz --- lib/copydir.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) Index: shadow-4.14.2/lib/copydir.c =================================================================== --- shadow-4.14.2.orig/lib/copydir.c +++ shadow-4.14.2/lib/copydir.c @@ -415,6 +415,7 @@ static int copy_entry (const struct path { int err = 0; struct stat sb; + struct stat tmp_sb; struct link_name *lp; struct timespec mt[2]; @@ -436,7 +437,7 @@ static int copy_entry (const struct path * If the destination already exists do nothing. * This is after the copy_dir above to still iterate into subdirectories. */ - if (fstatat(dst->dirfd, dst->name, &sb, AT_SYMLINK_NOFOLLOW) != -1) { + if (fstatat(dst->dirfd, dst->name, &tmp_sb, AT_SYMLINK_NOFOLLOW) != -1) { return 0; }